[antosubash]

Tech-debt batch 24 (from the 2026-10-28 scan).

Closes #690
Closes #691
Closes #696

What changed

• Module settings go through their editor (settings: module keys written through the generic settings store skip validation, env pin and hot reload #690).
  • The problem: generic settings writes to a system-scope <package>.<field> row, via /api/settings/system/{key}, CRUD by id, or Browse create/update/delete, skipped validation, the env-pin guard (Module settings: a DB-stored value overrides its SM_<MODULE>_* env var #486) and the hot reload. The value looked saved but did nothing until a restart.
  • API writes now return 422 with an edit_via pointer to the module editor. The Inertia Browse routes show the same message as a form error.
  • Tenant and user rows stay writable, since a tenant-overridable module key's per-tenant override has no other platform route.
  • Managed keys keep their more specific clear route, and orphaned rows for fields a module no longer declares stay deletable.
  • Browse's "New override" no longer suggests module keys.
• file_storage storage settings need a restart (file_storage: backend built once at startup; runtime storage settings changes split web and workers #691). The backend is built once at startup. The fix uses the issue's fallback: backend, fs_root_path and s3_* are marked requires_restart, instead of hot-swapping a backend with in-flight multipart sessions. Before, a change silently split the web process from the CSP, the workers and the tenant purge. The health-check docstring no longer claims a live re-read.
• Revert after save (settings: saving a defaulted field leaves db_override stale, hiding Revert #696). Saving a defaulted field now shows Revert at once. QA found that clicking that Revert, with no reload in between, left the edited value on screen; Revert now takes the live value from the reload response and clears the local override flag.

Verification

• make lint ✓ · make test-js ✓ · make test-py ✓ (6426 passed, 39 skipped)
• Code review fixes:
  • the guard is limited to system scope;
  • Browse view routes flash the refusal instead of returning raw 422 JSON;
  • managed-key precedence is restored;
  • orphaned rows stay deletable.
• Browser QA (playwright-cli):
  • creating users.allow_signup in Browse is refused inline and the page stays intact;
  • no module keys in suggestions; a generic key can be created, edited and deleted; the API returns 422 with edit_via;
  • Save then Revert works on two fields with no reload;
  • the file_storage page shows the RESTART badge on edited storage fields.
  • One bug (Revert after save) was found, fixed with a red-then-green Vitest test, and re-tested live.
• Rebase note: the CHANGELOG.md [Unreleased] conflict was resolved as the union of both sides.

https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
🔒 Security Review	✅ Completed 2026-10-30T07:58:05.968675Z	7b81ed5	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[cloudflare-workers-and-pages]

Deploying simple-module-python with    Cloudflare Pages

Latest commit:	7b81ed5
Status:	✅  Deploy successful!
Preview URL:	https://a89678ca.simple-module-python.pages.dev
Branch Preview URL:	https://tech-debt-b24-settings-stora.simple-module-python.pages.dev

View logs