Repository navigation
UI fixes: reset-password policy reason, command palette focus, settings field layout, sidebar contrast (#667–#670) - #672
Merged
Merged
Conversation
…ry with the same token (#667) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
… when narrow, wrap long identifiers (#669) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…ette" This reverts commit 25668ef.
Deploying simple-module-python with
|
| Latest commit: |
1aa460f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://255f4fe7.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-batch-21.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These were reported downstream against 0.0.38; all four reproduce on main.
RESET_PASSWORD_INVALID_PASSWORD, the reset-password page shows the password-policy reason instead of a misleading generic error, and the same link still works for a retry. A backend test confirms a rejected password doesn't consume the token.onCloseAutoFocus, passed through the shadcnCommandDialog.SM_*identifiers wrap.--color-app-sidebar-text-mutedgoes fromoklch(0.55 0.01 250)tooklch(0.62 …): 4.00 → 5.33:1 on the sidebar and 3.57 → 4.75:1 on hover, still dimmer than normal sidebar text. A Vitest test checks every shipped sidebar token pair.Closes #667
Closes #668
Closes #669
Closes #670
Verification
make lint,make test-py(6332 passed),make test-js(861 passed) andmake ci-css-buildare green.QA Report
Test plan