Repository navigation
Tech-debt batch 20: follow-ups — admin refusal reasons, OAuth refusal page, eager outbox serialization, refresh-family max age, token purge on user delete, bearer /me (#653–#658) - #671
Merged
Conversation
…nant teardown test covers both module orders (#655) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…_family_max_age_days, default 90); pruning removes expired families (#656) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…lated message (#654) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
a0f5db6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9630d3d7.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-debt-batch-20.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/users/login?oauth_error=<code>. The codes are allowlisted (account_not_verified,signup_disabled,signin_failed) and the login page shows a translated message for each. API and XHR callers keep the JSON error. Provider and token-exchange errors are caught as well.OutboxTransportserializes eager dispatches, so chained durable publishes no longer overlap on one connection. This fixes the order-dependentHandlerCommitErrorin the tenant-teardown test, which now runs under both module orders.refresh_token_family_max_age_days, default 90. A refresh in an older family is refused and the whole family is revoked; pruning revokes, then removes, expired families. Reuse evidence for live families is unchanged.api_tokenspurges a deleted user's personal tokens on the durableUserDeleted. Service keys and other users' tokens are kept.GET/PATCH /api/users/meresolve the request principal, so a session or a Bearer access token both work. Tests that used/meto probe the cookie strategy now call the strategy directly.Closes #653
Closes #654
Closes #655
Closes #656
Closes #657
Closes #658
Verification
/mereturns 200, and 401 without credentials./admin/settings.make lint,make test-py(6330 passed) andmake test-js(835 passed) are green.QA Report
Test plan