Repository navigation
Tech-debt batch 19: site-lock limiter eviction, API token pagination, duplicate-share race, UserUpdate fields, shared UTC helpers (#640) - #652
Merged
Conversation
…ate share race, UserUpdate privileged fields, shared UTC helpers (#640) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All items are from #640:
AttemptLimiterevicts expired buckets once per window, so the per-process dict no longer grows without bound.limit(1–100, default 100) andoffset, orderedcreated_at desc, id desc. A client that relied on getting every token in one response now gets the first 100.paginationprop and Previous/Next controls.revoke_all_for_ownerwalks every page, so revoking more than 100 tokens still covers them all.IntegrityError.UserUpdateno longer carriesis_active,is_superuseroris_verified. Every call site already passed only safe fields.simple_module_core.datetimes(utcnow,aware) replaces the per-module copies in sharing, tenants, background_tasks, api_tokens and users.#639 was closed separately as already fixed (#605 and #646).
Closes #640
Verification
?limit=2, and revoking on page 2 stays on that page.limit=0andlimit=101return 422.make lint(including API-type freshness),make test-py(6195 passed) andmake test-js(771 passed) are green.QA Report
Test plan