Repository navigation
Tech-debt batch 18: frontend — settings drafts and connection tests, VerifyEmail states, native downloads, inert mobile drawer (#637 #638) - #651
Merged
Conversation
… module, unreadable check responses fail (#637) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…a, closed mobile drawer is inert (#638) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Deploying simple-module-python with
|
| Latest commit: |
dcc3eb7
|
| Status: | ⚡️ Build in progress... |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModuleFormis keyed by package.TestConnectionButtonresets on module switch and drops stale in-flight responses. An unreadable or empty check response now reports failure instead of success.@simple-module-py/ui:readBodyrethrows a body-read failure, andapiFetchreports it as a network failure (status 0).VerifyEmailshows "expired" only forVERIFY_USER_BAD_TOKEN, "already verified" forVERIFY_USER_ALREADY_VERIFIED, and a generic error otherwise.data-native-link, so they bypass Inertia; S3 signed-URL redirects work.inertandaria-hidden. The desktop sidebar is unaffected.Closes #637
Closes #638
Verification
/users/verify?token=garbageshows "Link expired".make lint,make test-py(6183 passed) andmake test-js(794 passed) are green.QA Report
Test plan