Repository navigation
Tech-debt batch 11: framework/db — connection-bound policy, savepoint on_commit, soft-delete audit (#630 #631 #632) - #641
Merged
Merged
Conversation
Deploying simple-module-python with
|
| Latest commit: |
24fb375
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8b9e1d84.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-debt-batch-11.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tech-debt batch 11 — framework/db correctness fixes from the 2026-10-24 scan.
engine_policy()now resolves aConnectionbind to its engine, so sessions created withbind=connectionkeep strict tenancy (TenantIsolationError) and the audit callback instead of silently turning both off.on_commitcallbacks survive a savepoint rollback #631on_commitcallbacks remember the savepoints they were registered in; rolling back a savepoint discards them, and a root rollback discards everything (no leak into the session's next transaction).soft_deleted#632 The soft-delete listener re-adds persistent rows as dirty, so the audit snapshot now classifies them fromsession.dirtyassoft_deletedand carries any field edits made in the same flush (review follow-up), instead of auditing them as plainupdated. The old test faked the path withmake_transient(); it now deletes for real.Verification
mainand passes on the branch.make lint✓ ·make test-py(8 workers) ✓ 6005 passed (one env-only failure, the known/tmp/.gitplaceholder, re-run green) ·make test-js✓ 770 passed.framework/db/tests+modules/audit_log/tests✓ 685 passed.createdthensoft_deleted; double delete 404; admin pages 200 (verified over HTTP — the shared Playwright browser was unavailable).Closes #630
Closes #631
Closes #632
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4