Skip to content

Tech-debt batch 11: framework/db — connection-bound policy, savepoint on_commit, soft-delete audit (#630 #631 #632) - #641

Merged
antosubash merged 4 commits into
mainfrom
fix/debt-batch-11
Oct 24, 2026
Merged

antosubash merged 4 commits into
mainfrom
fix/debt-batch-11

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Tech-debt batch 11 — framework/db correctness fixes from the 2026-10-24 scan.

Verification

  • Red/green per issue: each new test failed on main and passes on the branch.
  • make lint ✓ · make test-py (8 workers) ✓ 6005 passed (one env-only failure, the known /tmp/.git placeholder, re-run green) · make test-js ✓ 770 passed.
  • Postgres: framework/db/tests + modules/audit_log/tests ✓ 685 passed.
  • /ship: optimize (nothing to remove) → code review (pass 1: 1 finding fixed — soft-delete diffs; pass 2 clean) → QA smoke: upload + delete a file → audit log shows created then soft_deleted; double delete 404; admin pages 200 (verified over HTTP — the shared Playwright browser was unavailable).

Closes #630
Closes #631
Closes #632

https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 24fb375
Status: ✅  Deploy successful!
Preview URL: https://8b9e1d84.simple-module-python.pages.dev
Branch Preview URL: https://fix-debt-batch-11.simple-module-python.pages.dev

View logs

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-24T10:58:18.689980Z 24fb375 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@antosubash
antosubash merged commit 288055a into main Oct 24, 2026
17 checks passed
@antosubash
antosubash deleted the fix/debt-batch-11 branch October 24, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant