Repository navigation
Tech-debt batch 7: users durable checkpoints via independent_session, internal split; domain errors in users/settings (#592 #595) - #612
Merged
Conversation
…-session commits; split internal subsystems into subpackages Closes #592 Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…lers; document the convention Closes #595 Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
A rollback that discards nothing logs at DEBUG, so failed logins no longer warn; docs note SQLite's single writer for independent_session. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Registration releases the fastapi-users connection before the default-role checkpoint, so single-connection pools no longer deadlock. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
40922db
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://af92e748.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-debt-batch-7.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commit()calls in users now go throughsimple_module_db.independent_session, a short-lived session from the app's factory that commits on exit and supportson_commit. The six are registration's default-role attach, three in login lockout and two in bulk invite. Ordering is preserved: lockout still reserves an attempt before authenticating, and invites commit before mail is sent. Registration releases the fastapi-users connection before its checkpoint, so single-connection pools no longer deadlock (regression test withpool_size=1). A rollback that discards nothing logs at DEBUG, so failed logins no longer warn. Lockout, invite and demo code moved into internal subpackages; nothing outside users imported them.docs/database/sessions.mddocuments the helper and SQLite's single-writer rule.Retry-After). The convention is indocs/module-authoring.md, the module scaffold and the shipped skills.Follow-up filed during review: #611 (pre-existing: the demo read-only guard keys on the session, not the resolved identity).
Verification
8218: lockout (429 + Retry-After, refused while locked, admin unlock), registration with the default role, bulk invite results, settings validation 422; no 5xxmake lint,make test-py(5767 passed),make test-js(748 passed), full e2e suite (49 passed); users, settings and framework/db on Postgres (1407 passed)QA Report
Test plan
/admin/usersrestores sign-inCloses #592
Closes #595
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4