Repository navigation
Tech-debt batch 6: CI parity and timeouts, resumable releases, dependency caps, docs drift (#598 #599 #600 #602) - #610
Merged
Merged
Conversation
…e for python tests, make migration LABEL= Closes #598 Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…stgres tests on users/background_tasks/file_storage Closes #599 Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
… role at startup Closes #600 Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…perseded banners, Postgres testing docs Closes #602 Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…on-target test independent of MAKELEVEL Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Startup role seeding commits per role and tolerates a concurrent insert; CLAUDE.md lists the widened Postgres path filter. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Release pre-flight accepts operator-confirmed pending publishers (no deadlock for new packages); pyyaml declared as a dev dependency; startup seeds only the default user role; users test fixture refreshes the role cache after direct inserts. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
03ef63c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7adb2a51.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-debt-batch-6.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-check-hardcoded-stringsruns in CI. A newscripts/check_ci_parity.py(make ci-check-ci-parity, inmake lintandpython-lint) fails if amake lintprerequisite is missing frompr.yml. Every job hastimeout-minutes. Python test jobs install Node, so asset tests run instead of silently skipping.make migrationrequiresLABEL=and autogenerates against<label>@head.pending_publishersdispatch input (packages with a registered pending publisher still 404 until their first upload). Publish legs skip versions that already exist, so a half-failed release can be re-run.postgres-tests.ymlnow also runs formodules/users,modules/background_tasksandmodules/file_storage.userrole at startup when missing, so apps scaffolded from a schema-only baseline can register users; the admin role is not recreated.register_setup_stepsis documented inlifecycle.md, and a test asserts everyModuleBase.register_*hook is documented.docs/superpowers/{specs,plans}is the canonical design-doc location (docs/plans/README.md). Superseded banners on the April migration plans. Postgres testing docs match Speed up the Python test suites: per-worker Postgres DBs, schema reuse, lazy route resolution #577/chore(test): default pytest-xdist to 4 workers instead of -n auto #606.Verification
8217: with theuserrole deleted before boot, startup recreated it and signup → sign-in worked; the new user is non-adminmake lint(incl. the new parity check),make test-py(5753 passed),make test-js(748 passed), full e2e suite (49 passed), users on Postgres (680 passed);uv lock --checkagainst the live indexQA Report
Test plan
Closes #598
Closes #599
Closes #600
Closes #602
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4