Repository navigation
Tech-debt batch 5: one is_public() for every public-route check; framework hygiene (#593 #594) - #608
Merged
Merged
Conversation
…r failures are logged Closes #593 Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…d compat paths, route contract, leaf modules Closes #594 Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Every unversioned module (all in-repo ones) warned on each boot, flooding test runs with ~27k warnings; the bypass stays tracked by the deprecation-expiry test. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
A failing legacy auth provider is logged once per process instead of per request. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Process state resets stay per-test (a second app no longer clobbers the first); auth declares its simple_module_hosting dependency. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
7dfcaeb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://923cc16f.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-debt-batch-5.simple-module-python.pages.dev |
…-batch-5 # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simple_module_hosting.public_access.is_public(app, method, path)is the single answer to "is this route public?" forAuthMiddleware, maintenance mode, rate limiting and theSM031check (which keeps its placeholder substitution on top). The legacyget_public_paths()fallback goes throughlegacy_provider_public_paths(one deprecation warning per provider class); a provider that raises is logged once per process instead of silently treated as not public. Superseded banners on the two old specs that still taughtget_public_paths().app.stateaccessors, deferred as noted on the issue):docs/framework-conventions.md.register_event_handlers(app=None)default and therequires_framework=Nonebypass are dated for removal in 0.1.0 and tracked bytest_deprecation_expiry.py. No per-module runtime warning: it flooded every boot.Route.matchescontract test for the route guard.run_deferred_startupand the error-page renderer moved to leaf modules, so no lazy imports dodge cycles.modules/authnow declares its existingsimple_module_hostingdependency (+uv.lock).Verification
8216: anonymous public vs protected routes, maintenance mode on/off (503 HTML/JSON, health and sign-in reachable, admin bypass),/setupclosed; no console errorsmake lint,make test-py(5708 passed),make test-js(748 passed), full e2e suite (49 passed); framework db/testing/hosting/core + auth on Postgres (2188 passed)QA Report
Test plan
/answers 503,/healthand/users/loginstay reachableCloses #593
Closes #594
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4