Repository navigation
Tech-debt batch 4: sqlmodel col() sweep, shared user-directory SQL helpers (#591 #596) - #607
Merged
Merged
Conversation
Deploying simple-module-python with
|
| Latest commit: |
cfdcede
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf6defae.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-debt-batch-4.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ty: ignore[invalid-argument-type]on column comparisons withsqlmodel.col()#591: SQLModel column comparisons and orderings across ~38 shipped files now usesqlmodel.col(...), which removes 99# ty: ignore[invalid-argument-type]suppressions. Shipped-codety: ignorecount goes from 174 to 75 (invalid-argument-typefrom 132 to 33). One ignore stays onselectinload(User.roles), a relationship false positive. No behaviour change.DirectoryUserconversion live once, insimple_module_db.user_directory_sql, used by bothusersandkeycloak. A framework test covers%,_and backslash escaping and the unknown-vs-empty roles semantics. Keycloak's UUID-as-text shim stays local.Internal refactors only; no CHANGELOG entry.
Verification
/admin/usersand/admin/audit-logon port8215: literal%/_search, active/disabled filters, sorting; no console errors, no 5xxmake lint,make test-py(5691 passed),make test-js(748 passed), full e2e suite (49 passed); users, keycloak and framework/db on Postgres (1128 passed)QA Report
Test plan
%on/admin/users: no rowsCloses #591
Closes #596
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4