Repository navigation
Tech-debt batch 1: delete after commit, queued upload cancel, optional settings, generated admin password (#582 #584 #585 #587 #588) - #603
Merged
Conversation
…ed objects Closes #582 Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…ading format in docs Closes #584 Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…; order file_storage after BackgroundTasks Closes #585 Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…a disposable worktree Closes #587 Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Generated bootstrap password is logged once by the users module when it actually seeds; filesystem reaper walk skips multipart parts and runs off the event loop. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Deploying simple-module-python with
|
| Latest commit: |
b0a8bb7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://692b9fab.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-debt-batch-1.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETEdrop the stored bytes only after the request transaction commits (register_on_commit), so a failed commit no longer leaves a live row with no bytes. New hourlyfile_storage.reap_objectsbeat task (needsbackground_tasks) retries objects of soft-deleted rows and removes objects left by uploads whose row never committed, after twice the upload-session TTL. It only touches keys shaped like this module's own (constants.OWN_KEY), skips the multipart staging dir and walks the filesystem off the event loop.settingsmodule is enabled (it used to 500 withImportError).file_storagenow listsBackgroundTasksinoptional_depends_on.git reset --hard HEAD~1#587 Docker (behaviour change): withSM_USERS_BOOTSTRAP_PASSWORDunset the entrypoint generates a random password; the users module logs it once, only when it actually seeds the first admin. An explicitchangemeis refused in production.docs/release.md's rehearsal runs in a disposable worktree instead ofgit reset --hard HEAD~1.finalizeby Release gate, lockstep JS versions, dated CHANGELOG cut; enforced removal versions for compat shims (#510 #515) #572 (after v0.0.37 shipped), so the issue's premise was out of date. Added tests that pin the cut step order and both heading separators, fixed the heading format in the docs, and noted inCHANGELOG.mdthat 0.0.28–0.0.37 entries are still under[Unreleased].Verification
/file-storage/and/tenants/settingson port8211; no console errorsmake lint,make test-py(5633 passed),make test-js(748 passed), full e2e suite (49 passed)QA Report
Test plan
/file-storage/: the row goes and its download URL 404sSM_MODULES_ENABLEDexcluding Settings,/tenants/settings404s and the menu item is goneCloses #582
Closes #584
Closes #585
Closes #587
Closes #588
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4