Skip to content

Tech-debt batch 1: delete after commit, queued upload cancel, optional settings, generated admin password (#582 #584 #585 #587 #588) - #603

Merged
antosubash merged 10 commits into
mainfrom
fix/debt-batch-1
Oct 22, 2026
Merged

antosubash merged 10 commits into
mainfrom
fix/debt-batch-1

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

Verification

  • Browser-verified at /file-storage/ and /tenants/settings on port 8211; no console errors
  • Local CI: make lint, make test-py (5633 passed), make test-js (748 passed), full e2e suite (49 passed)
  • Verification report: https://claude.ai/artifact/Y1Ptog2u3RiJDL5nXASjwF

QA Report

  • Full QA cycle completed (1 iteration)
  • 0 bugs found, 0 fixed (2 P3 observations: no distinct "Queued" label; cancel clicked after a 100% upload is a no-op, both pre-existing)
  • Categories tested: Happy Path, Error States, Edge Cases (form validation folded in: only upload/delete inputs)
  • Full QA report: https://claude.ai/artifact/1Kqh4FdYx4KVrAm7ZzuNVe

Report links are Claude Artifacts and start private; the author can share them from claude.ai/code/artifacts if reviewers need access.

Test plan

  • Delete a file on /file-storage/: the row goes and its download URL 404s
  • With SM_MODULES_ENABLED excluding Settings, /tenants/settings 404s and the menu item is gone
  • CI is green

Closes #582
Closes #584
Closes #585
Closes #587
Closes #588

https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4

Generated bootstrap password is logged once by the users module when it actually seeds; filesystem reaper walk skips multipart parts and runs off the event loop.

Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: b0a8bb7
Status: ✅  Deploy successful!
Preview URL: https://692b9fab.simple-module-python.pages.dev
Branch Preview URL: https://fix-debt-batch-1.simple-module-python.pages.dev

View logs

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-22T18:03:06.945257Z b0a8bb7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@antosubash
antosubash merged commit 3be123b into main Oct 22, 2026
17 checks passed
@antosubash
antosubash deleted the fix/debt-batch-1 branch October 22, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment