Repository navigation
Typed client for the remaining modules + raw-fetch gate, frontend splits, UX polish (#504 #522 #575) - #579
Merged
Conversation
…test-connection (#504) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…piFetch for resumable uploads; Browse split (#504 #522) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…c operation ids, CHANGELOG (#504) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Clears both SM014 warnings. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…k origin A self-service password change deleted every UserAccessToken row for the account, including the one behind the changing browser's sm_auth cookie, which fastapi_users.current_user reads on /api/users/me*. The Starlette session was re-stamped, so pages kept rendering while /api answered 401 (pre-existing on main, not a regression of the typed-client migration). The endpoint now reissues that cookie under the new session_version, keeping a remembered sign-in's window; other sessions and bearer tokens are still revoked. Password and sessions cards show failures inline. Admin-copied links (reset link, bulk-invite fallback) no longer use the users.base_url dev default: an explicit users.base_url wins, then HostSettings.public_base_url, then the request origin. Emails unchanged. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…mber window The password-change reissue duplicated the remembered-login cookie and strategy construction and minted for the window the session recorded at sign-in, so an operator who shortened remember_me_max_age_seconds still saw new credentials minted for the old, longer window. Both paths now go through users.backend.cookie_login_response, and the reissue mints for the current setting, as a fresh login would. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
944f9e0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://02e47d0e.simple-module-python.pages.dev |
| Branch Preview URL: | https://feat-typed-client-b4b.simple-module-python.pages.dev |
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finishes the typed API client migration (#504), adds the raw-fetch gate, does #522's frontend file splits and the #575 UX fixes, and fixes two bugs that QA found.
What changes
api.*+apiResult, orapiFetchfor multipart uploads, non-/apiroutes and untyped endpoints. That covers users, background_tasks, branding, settings, file_storage and the setup wizard.bodySerializer. Register usesapiFetch, because the generatedUserCreatetype would make sign-up send privileged fields.pages/api.generated.ts.ci-check-no-raw-fetch(runs inmake lintand CI): a rawfetch(outsidepackages/ui/src/lib/api*.tsfails unless the line has a// raw-fetch-ok: <reason>marker. No markers are needed today.detailor a translated fallback, instead of English text or "HTTP n".users/pages/Users/AddPeople.tsx: 297 → 136 lines (useAddPeople,MailerBanner).file_storage/pages/Browse.tsx: 297 → 223 lines (useFileActions,BrowseEmpty).packages/uiSidebarLayout.tsx: 298 → 218 lines (SidebarNav,SidebarBrandRow).useActionhook is covered byapiResult+useApiErrorToast.SettingDefinition.label_key./adminkeep the app layout./apitoken (pre-existing on main). The browser now gets a fresh access token through the shared login cookie builder, with the current remember-me window. Every other session and token is still revoked.localhost:8000. They now useusers.base_url, thenpublic_base_url, then the request origin. Emailed links are unchanged.Verification (after merging main)
make lint✓make test-py: 5605 ✓make test-js: 747 ✓make ci-api-types-fresh✓make ci-doctor: 0 warnings ✓uv lock --check✓/ship
Two rounds.
Closes #504
Closes #522
Closes #575
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4