Repository navigation
Split near-cap Python files by responsibility (#522, Python half) - #578
Merged
Merged
Conversation
Deploying simple-module-python with
|
| Latest commit: |
3074280
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cd466015.simple-module-python.pages.dev |
| Branch Preview URL: | https://chore-file-splits-522.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the 14 Python files that sat at or near the 300-line cap, along lines of responsibility, before the next feature forces a rushed split (#522). Behaviour does not change.
Splits
Modules
service.py300 → 184 lines. Membership operations move to_membership_ops.py.service.py296 → 214 lines. Registry sync and effective-permission resolution move to_registry_sync.py; role and user CRUD stay.service.py299 → 210 lines (deletes move todeletes.py).module.py290 → 236 lines (audit_labels.py,body_limits.py).settings.py300 → 143 lines. Celery, worker and retention fields move tosettings_celery.py. Field order is unchanged.Framework
migrations.py300 → 235 lines (_migration_render.py).bulk_audit.py291 → 193 lines (_bulk_audit_records.py).permissions.py300 → 241 lines (_permission_grants.py).i18n.py292 → 198 lines (_i18n_translator.py).app_project.py300 → 219 lines (_app_project_manifests.py).add_cmd.py298 → 184 lines (_add_install.py,_add_sources.py).host_settings.py297 → 245 lines (_host_settings_support.py).app_builder.py297 → 247 lines (_app_boot.py)._phase_helpers.py297 → 110 lines (_middleware_pipeline.py).What does not change
Still open in #522
The frontend splits (
file_storage/pages/Browse.tsx→useFileActions,users/pages/Users/AddPeople.tsx,packages/uiSidebarLayout.tsx) and the shareduseAction/DataTablepieces. They land with the next typed-client batch, which rewrites those pages anyway.Verification
make lint✓make test-py: 5566 passed ✓Part of #522
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4