Repository navigation
fix(user-directory): #501 follow-ups — activity feed at startup, empty labels, fewer stats queries - #569
Merged
Conversation
…up, empty labels, single-query stats) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…, tests, changelog Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
e70c7fc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b955fb5a.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-user-directory-followups.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups to #501 (#566), found while reviewing another branch.
audit_lognow installs itsActivityFeedinon_startupand clears it inon_shutdown, instead of inregister_settings. Overridingregister_settingswithout settingapp.state.audit_logtriggered SM012. Only per-request code reads the feed, after the lifespan has started.resolve_user_labelsdrops users whose label is empty, for example a Keycloak cache row with no name or email. Callers already fall back to the raw id.select_from(User), so soft-delete and tenant filters still apply. The numbers and theNonesemantics are unchanged.Verification
make lintpasses;make test-py: 5114 passed, 22 skipped.select_fromand added the missing tests.Test plan
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4