Repository navigation
chore(ci): make lint and CI run the same checks (#508) - #563
Merged
Merged
Conversation
…ommit uv.lock (#508) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…r-event pg concurrency Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Deploying simple-module-python with
|
| Latest commit: |
df65583
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d1f04807.simple-module-python.pages.dev |
| Branch Preview URL: | https://chore-ci-parity-508.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #508.
make lintworks on a fresh clone.ci-js-typechecknow depends ongen-pages.ci-check-metadata(metadata + READMEs),ci-i18n-fresh,ci-css-buildandci-doctormake targets.make lintandpr.ymlcall the same targets.check_readmes.pyandmake doctornow gate PRs. Doctor runs against a freshly migrated SQLite file, and the newdoctorjob is inpr-checks.postgres-tests.ymlrunsmake test-py-pg. It runs nightly, on manual dispatch, and on PRs touchingframework/db,framework/testing,modules/tenants,host/migrationsor the workflow file itself. It is not a required check.type Reactimports and the useless fragment inErrorPage.test.tsx.biome cinow runs with--error-on-warnings.uv sync --locked(UV_SYNC_FLAGS) and keys its caches onuv.lock.release.ymlre-locks after the version bump.pyproject.tomlmust commit the refresheduv.lock.Verification
make lintpasses.make test-py: 4952 passed, 22 skipped.make test-js: 668 passed.make ci-css-build: 2 passed.make ci-doctor: 0 errors, 0 warnings.uv.lockafter the release bump.Test plan
doctorjobPostgres testsworkflow passes on this PRhttps://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4