Skip to content

chore(ci): make lint and CI run the same checks (#508) - #563

Merged
antosubash merged 3 commits into
mainfrom
chore/ci-parity-508
Oct 21, 2026
Merged

antosubash merged 3 commits into
mainfrom
chore/ci-parity-508

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

Closes #508.

  • Fresh clone: make lint works on a fresh clone. ci-js-typecheck now depends on gen-pages.
  • Same checks locally and in CI: new ci-check-metadata (metadata + READMEs), ci-i18n-fresh, ci-css-build and ci-doctor make targets. make lint and pr.yml call the same targets.
    • check_readmes.py and make doctor now gate PRs. Doctor runs against a freshly migrated SQLite file, and the new doctor job is in pr-checks.
  • Postgres suite: new postgres-tests.yml runs make test-py-pg. It runs nightly, on manual dispatch, and on PRs touching framework/db, framework/testing, modules/tenants, host/migrations or the workflow file itself. It is not a required check.
  • Biome: fixed the 7 unused type React imports and the useless fragment in ErrorPage.test.tsx. biome ci now runs with --error-on-warnings.
  • uv.lock:
    • It was gitignored and untracked, despite what the issue says. It is now committed.
    • CI runs uv sync --locked (UV_SYNC_FLAGS) and keys its caches on uv.lock.
    • release.yml re-locks after the version bump.
    • Process change: a PR that changes any pyproject.toml must commit the refreshed uv.lock.

Verification

  • Local CI is green:
    • make lint passes.
    • make test-py: 4952 passed, 22 skipped.
    • make test-js: 668 passed.
    • make ci-css-build: 2 passed.
    • make ci-doctor: 0 errors, 0 warnings.
  • Code review: clean after 2 passes. Five findings were fixed, including the stale uv.lock after the release bump.
  • No browser QA: there is no user-facing change.
  • Not yet run: the Postgres workflow. This PR triggers it through its path filter.
  • Report: https://claude.ai/artifact/KFT8rxwqzh28BbzwQDHDKr

Report links are Claude Artifacts and start private — the author can share them from claude.ai/code/artifacts if reviewers need access.

Test plan

  • CI is green, including the new doctor job
  • Postgres tests workflow passes on this PR

https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: df65583
Status: ✅  Deploy successful!
Preview URL: https://d1f04807.simple-module-python.pages.dev
Branch Preview URL: https://chore-ci-parity-508.simple-module-python.pages.dev

View logs

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-21T05:22:07.221022Z df65583 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@antosubash
antosubash merged commit cb34cf6 into main Oct 21, 2026
16 checks passed
@antosubash
antosubash deleted the chore/ci-parity-508 branch October 21, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make lint and CI are not equivalent (fresh-clone tsc failure, local-only checks, no Postgres suite / doctor in CI)

1 participant