Repository navigation
fix: QA follow-ups for #551 (owner-scoped usage, download CSP, settings defaults, inline errors) - #552
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
7d639f0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7d5459a6.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-p3-followups-551.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the four P3 observations from the browser QA of #551. Stacked on #551: the base is
fix/bug-batch-517-548, so this diff shows only the follow-ups. Once #551 merges it retargets tomain.Changes
file_storage.managenow sees only their own usage: oneSUMscoped bycreated_by, with no tenant quota shown. They used to see the tenant-wide total, which disclosed other users' aggregate storage. Managers keep the tenant figure and quota./api/file-storage/files/{id}/downloadnow sends the same sandbox CSP as public serving, alongsideattachmentandnosniff. Both routes share the newserving.sandbox_headers(). The thumbnail route already sent it, and a test now pins it.nullrow. Env-pinned fields are still refused first, and secrets are unwrapped before comparing.Verification
make lint,make test-jsand the full Python suite pass: 4644 passed, 21 skipped.attachment,nosniffanddefault-src 'none'; …; sandbox.https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4