Skip to content

fix(ui): layout batch (PageShell wrap, AlertDialog merge, skip link, toaster test) - #400

Merged
antosubash merged 1 commit into
mainfrom
fix/ui-layout-batch
Oct 7, 2026
Merged

antosubash merged 1 commit into
mainfrom
fix/ui-layout-batch

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Fixes #354
Fixes #348
Fixes #338
Fixes #341

Changes

Tests added for each. make lint, make test-js, make ci-check-untranslated pass.

https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4

… link

- PageShell: actions slot wraps/shrinks (#354)
- AlertDialogAction/Cancel compose buttonVariants on the primitive so caller classes tailwind-merge (#348)
- SidebarLayout: translated skip-to-content link, #main focus target (#341)
- Tests asserting a single Toaster in both Admin and Authenticated layouts (#338)

Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-05T09:59:38.189169Z abcb1bf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: abcb1bf
Status: ✅  Deploy successful!
Preview URL: https://04139d2a.simple-module-python.pages.dev
Branch Preview URL: https://fix-ui-layout-batch.simple-module-python.pages.dev

View logs

@antosubash

Copy link
Copy Markdown
Owner Author

/ship QA evidence

Pipeline: optimize (nothing to do) -> code-review (1 pass, 0 findings) -> browser QA (0 bugs) -> local CI. No code changes were needed; branch unchanged.

Browser QA against a fresh local instance (API 8100 / Vite 5250, SQLite):

Local CI: make lint exit 0 (incl. untranslated-strings, file-size, tsc, Biome); make test-js 61 files / 478 tests pass. Python untouched.

https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4

@antosubash
antosubash merged commit c08bbab into main Oct 7, 2026
13 checks passed
@antosubash
antosubash deleted the fix/ui-layout-batch branch October 8, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment