Repository navigation
fix(ui): layout batch (PageShell wrap, AlertDialog merge, skip link, toaster test) - #400
Merged
Merged
Conversation
… link - PageShell: actions slot wraps/shrinks (#354) - AlertDialogAction/Cancel compose buttonVariants on the primitive so caller classes tailwind-merge (#348) - SidebarLayout: translated skip-to-content link, #main focus target (#341) - Tests asserting a single Toaster in both Admin and Authenticated layouts (#338) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
abcb1bf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://04139d2a.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-ui-layout-batch.simple-module-python.pages.dev |
Owner
Author
/ship QA evidencePipeline: optimize (nothing to do) -> code-review (1 pass, 0 findings) -> browser QA (0 bugs) -> local CI. No code changes were needed; branch unchanged. Browser QA against a fresh local instance (API 8100 / Vite 5250, SQLite):
Local CI: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #354
Fixes #348
Fixes #338
Fixes #341
Changes
flex min-w-0 flex-wrap items-center justify-end gap-2(title block already hadmin-w-0), so toolbars wrap instead of overflowing.AlertDialogAction/AlertDialogCancelrender the Radix primitive directly withcn(buttonVariants({ variant, size }), className), so caller classes tailwind-merge. OtherasChildsites in packages/ui (DialogClose wrapping Button, triggers) don't have this problem.AdminLayoutmounts no<Toaster>, sotoast.*()is silently swallowed on every admin page #338<Toaster>already lives once inSidebarLayouton main (AuthenticatedLayout has none; no other Toaster mounts). Added a regression test that both Admin and Authenticated layouts render exactly one toaster.Skip to contentlink (sr-only focus:not-sr-onlywith visible focus styles) as the first focusable element inSidebarLayout, new keyui.sidebar.skip_to_contentin en/es catalogs, regenerated i18n keys/resources; main content wrapper hasid="main" tabIndex={-1}.Tests added for each.
make lint,make test-js,make ci-check-untranslatedpass.https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4