Skip to content

remove footer from the branding #273

Closed

Description

@antosubash

fotter is managed from the sitelayout so we done need that in the branding

Activity

  1. added
    bugSomething isn't working
    pi-readyApproved for the headless Pi worker
    pi-workingThe headless Pi worker is implementing this issue
    and removed
    pi-readyApproved for the headless Pi worker
    on Aug 21, 2026
  2. antosubash commented on Aug 21, 2026

    @antosubash
    OwnerAuthor

    🤖 Claimed. I am creating an isolated worktree from origin/main and starting implementation.

  3. added
    pi-pr-openThe headless Pi worker opened a draft pull request
    and removed
    pi-workingThe headless Pi worker is implementing this issue
    on Aug 21, 2026
  4. antosubash commented on Aug 21, 2026

    @antosubash
    OwnerAuthor

    ✅ Draft pull request opened: #275

    Summary

    • Removed configurable footer ownership from the branding module, including API routes, settings, contracts, shared props, editor components, and localization keys.
    • Restored framework-owned footer rendering in site layouts.
    • Updated branding documentation and added regression coverage confirming footer routes return 404.

    Changed areas

    • modules/branding/
    • packages/ui/
    • Generated packages/i18n/src/*
    • Branding documentation

    Verification

    • uv run --all-packages pytest modules/branding/tests — 114 passed
    • npx vitest run packages/ui/src/components/BrandingFooter.test.tsx — 3 passed
    • make lint — passed
    • uv run --all-packages python -m simple_module_core — 0 errors, one unrelated existing SM003 AuditLog warning
    • git diff --check — passed

    Evidence / risks

    • Visual evidence: none.
    • Existing persisted footer setting rows are left inert rather than destructively deleted.
    • No blockers.
  5. added a commit that references this issue on Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpi-pr-openThe headless Pi worker opened a draft pull request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions