Repository navigation
Request-scoped session exposes no post-commit hook, so module caches refresh against uncommitted state #268
Description
Activity
🤖 Claimed. I am creating an isolated worktree from
origin/mainand starting implementation.✅ Draft pull request opened: #278
Summary
- Added
RequestSession.on_commit(callback)supporting sync and async callbacks. - Callbacks run only after successful commits; rollback/read-only/failed commits discard them.
- Callback failures are logged without affecting committed responses or later callbacks.
- Exported the new session/callback types and documented usage.
Changed areas
- DB session/finalization runtime
- Framework DB public API
- Session documentation and changelog
- Transaction/session tests
Verification
uv run pytest framework/db/tests— 69 passed- Ruff format/check — passed
uv run ty check ...— passeduv run python scripts/check_file_size.py— passedgit diff --check— passed
Visual evidence: none required.
Risks/blockers: none.
- Added
- added a commit that references this issue
on Sep 4, 2026
Found while reviewing geowiki_public_website's map module (modules/geowiki_map/geowiki_map/service.py).
The module keeps a process-global cache of CSP origins derived from its table (the CSP middleware reads it on every response, so it cannot query per request). Writes refresh that cache — but the only points a module can hook are before commit: after
flush(), the transaction can still fail or roll back, leaving cache and database diverged until the next successful write or a restart.Concrete failure: a layer delete whose commit fails still removes that layer's origin from every response's Content-Security-Policy — the overlay goes dark site-wide with only console evidence. The create-side mirror pollutes the CSP with a host that was never committed.
What would fix it: a supported post-commit callback on the request-scoped session (e.g.
session.on_commit(fn)or an event the hosting layer fires after a successful commit), so modules can refresh derived caches only from committed state.Workaround today is refreshing after flush and accepting the divergence window, which is what geowiki does — noted in review rather than patched, since the correct fix lives here.