fix out-of-bounds read in antlr3UTF16LA backward surrogate peek - #240
Open
zayeem06 wants to merge 1 commit into
Open
fix out-of-bounds read in antlr3UTF16LA backward surrogate peek#240zayeem06 wants to merge 1 commit into
zayeem06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
antlr3UTF16LA handles negative (lookbehind) LA by scanning backwards, and when the previous unit is a low surrogate it peeks at *(nextChar-1) to see whether a matching high surrogate precedes it. If that backward scan reaches the start of the buffer the peek reads input->data[-1], two bytes before the allocation; this happens with UTF-16 input whose first code unit is a lone low surrogate followed by a negative LA. The forward branch already bounds the equivalent surrogate peek, so I added the matching lower-bound check before the backward peek. I confirmed the read under AddressSanitizer (heap-buffer-overflow of size 2, two bytes before the buffer) and verified it is gone with the guard in place.