fix invalid free of internal vector storage in replaceChildren - #238
Open
zayeem06 wants to merge 1 commit into
Open
fix invalid free of internal vector storage in replaceChildren#238zayeem06 wants to merge 1 commit into
zayeem06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaceChildren builds a temporary vector with antlr3VectorNew(1) when the replacement tree is not a nil node, and for any size hint at or below ANTLR3_VECTOR_INTERNAL_SIZE antlr3SetVectorApi points elements at the vector's own inline internal[] array instead of a separate heap block, so the cleanup path hands free() an interior pointer into the vector struct. Any tree rewrite that replaces children with a non-nil node hits it; under ASAN it aborts with "attempting free on address which was not malloc()-ed ... 16 bytes inside of 352-byte region" at antlr3basetree.c:454. The same block also assigned 0 to newChildren->size, which is the vector's size() function pointer rather than a count field. Calling the vector's own free() instead is the fix, since it already guards the elements release with elementsSize > ANTLR3_VECTOR_INTERNAL_SIZE; worth verifying that the replacement nodes still survive, which they do because they were added with a NULL freeptr, so the original "will not free the nodes" behaviour is unchanged.