fix oob read in UTF-16 byte-swap LA from wrong nextChar pointer type - #237
Open
zayeem06 wants to merge 1 commit into
Open
fix oob read in UTF-16 byte-swap LA from wrong nextChar pointer type#237zayeem06 wants to merge 1 commit into
zayeem06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
antlr3UTF16LALE and antlr3UTF16LABE declare their scan pointer nextChar as pANTLR3_UCHAR, which is a UINT32*, but the code assembles each character a byte at a time and steps with nextChar += 2, so every access reads four bytes and strides in four-byte units. A well-formed UTF-16 source whose byte order is opposite to the host (for example a UTF-16BE file on a little-endian build, which selects these byte-swap routines) then reads past the end of the input buffer and hands back wrong code points; ASAN reports a heap over-read at the character fetch. Declaring nextChar as pANTLR3_UINT8 makes the byte arithmetic match the reads.