fix off-by-one null terminator in toUTF8_UTF16 - #233
Open
zayeem06 wants to merge 1 commit into
Open
Conversation
Author
|
any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Off-by-one terminator in toUTF8_UTF16
The UTF-16 to UTF-8 converter in runtime/C/src/antlr3string.c writes its terminator at
*(outputEnd+1)afterConvertUTF16toUTF8leavesoutputEndone past the last byte, so it lands a byte too far. On an empty UTF-16 string the buffer is a single byte (size = len*3 = 0,malloc(1)) and the write goes to index 1, one byte past the allocation; on non-empty input it leaves a stray uninitialized byte in front of the terminator. Terminating at*outputEndwrites at the byte the converter actually stopped on, which is always inside thesize+1allocation.Reviewers may want to confirm the empty-string path:
newStr8("")->toUTF8reaches this withlen == 0. ASan flags a 1-byte heap-buffer-overflow write there before the change and is clean after.