Tighten gRPC response content-type validation#200
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content-typeprefix check with strict protocol-and-codec-aware validationapplication/grpcandapplication/grpc-web) while still stripping parametersapplication/grpc; charset=utf-8Why
The previous
starts_with("application/grpc")check acceptedapplication/grpc-web*and never verified that the response codec matched the client configuration. That let a gRPC client accept gRPC-Web framing and could let a proto-configured client try to decode JSON bytes as proto.Impact
application/grpcremains accepted as the default proto subtype, even with parametersValidation
cargo test -p connectrpc grpc_unary_cargo test -p connectrpc grpc_web_unary_stops_reading_after_trailer_frame