Preserve transport ConnectErrors in client calls#199
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectErrors instead of remapping them toUnavailablehttps://configuration mismatch across all five call shapesWhy
HttpClient::send()already classifies local scheme/config mismatches asInvalidArgument, but the higher-level client call helpers wrapped every transport error asUnavailable. That made local caller bugs look like retryable outages and obscured the real cause.Impact
ConnectErrorclassificationUnavailableConnectErrorin their source chain are preserved tooValidation
cargo test -p connectrpc --features client preserves_transport_connect_errorcargo test -p connectrpc transport_send_error_mapper_preserves_connect_error_in_source_chaincargo test -p connectrpc --features client http_client_plaintext_rejects_https