fix(view): preserve packed closed-enum unknowns#252
Open
ogarciarevett wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed proto2 enums already preserve unknown values on the owned path, but the packed repeated view path was still dropping them.
This keeps those packed unknown values by letting
UnknownFieldsViewhold synthetic unknown fields for cases where there is no borrowable per-element wire span.I also added a regression test for the packed repeated view case and removed the corresponding item from the README limitations list.
Proof:
mainin a clean worktree:cargo test -p buffa-test 'tests::closed_enum::test_view_closed_enum_repeated_packed_unknown_preserved' -- --exactcargo test -p buffa-test 'tests::closed_enum::test_view_closed_enum_repeated_packed_unknown_preserved' -- --exactcargo test -p buffa 'view::tests::unknown_fields_view_to_owned_includes_owned_fields' -- --exactcargo clippy --workspace --all-targets -- -D warningsandcargo test --workspace