Repository navigation
Conversation
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_prepare_optionsin the Bedrock client copies theanthropic-betaheader into the body asanthropic_betaby splitting on,without trimming. A header such as"context-1m-2025-08-07, other-beta"became["context-1m-2025-08-07", " other-beta"], and a trailing comma added an empty entry, so Bedrock received beta names it does not recognise.This change strips each entry and drops empty ones, which matches the TypeScript Bedrock client and the other places in this SDK that parse the header. A header that is already comma separated without spaces produces the same list as before. If nothing is left after stripping,
anthropic_betais not set, as before for an empty header.Test:
test_prepare_options_strips_whitespace_from_anthropic_beta_headerintests/lib/test_bedrock.pyfails onmainand passes with the fix. The rest oftests/libpasses.No public names or signatures change.
Fixes #2023