Repository navigation
feat: give each engine a stable instance id and a unique name - #43
Merged
Merged
Conversation
- instance_id: random UUID generated once, kept in /data/instance.json - instance_name: INSTANCE_NAME or 'Smart Frame Engine <id prefix>' - exposed on GET /api/health and in the Zeroconf TXT record; the mDNS service name is the instance name and registration may rename on conflict, so two engines on one LAN coexist - contract 1.1 (additive), openapi.json regenerated, package version 1.0.0rc2 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VzFCH4ztqBYejkvLvFgnaq
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two engines on one LAN advertised the same mDNS name (
Smart Frame Engine), and clients had no stable identity to key on.instance_id: random UUID generated once, stored in/data/instance.json, never derived from hardware.instance_name:INSTANCE_NAME, elseSmart Frame Engine <first 6 chars of the id>.GET /api/health(still public) returns both; Zeroconf TXT carriesinstance_id, the service name is the instance name, and registration usesallow_name_change=Trueso a clash renames instead of silently disabling advertising.api_versionstays 1):docs/API_CONTRACT.mdchangelog anddocs/openapi.jsonupdated. Package version bumped to1.0.0rc2.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01VzFCH4ztqBYejkvLvFgnaq