fix(sdk): bind embedded transport at request time - #46971
Open
kitlangton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An Effect application that supplies
FetchHttpClient.Fetchcan accidentally redirect embedded SDK requests away from their in-process host. Evenclient.health.get()uses the caller's Fetch instead of the embedded router. The Core test harness's network guard exposed this in all three Effect instance tests.Providing Fetch while constructing
FetchHttpClient.layeris not sufficient: Effect resolves that reference when each request executes, and the caller's context can override the captured value.What Changes
Bind the owning host's Fetch around the HTTP response effect for every SDK request using
HttpClient.transformResponseandEffect.provideService.http://opencode.local, causing failures or sending them to the wrong transport.OpenCode.layer.Scope
This changes the shared Effect SDK constructor, also used by the Effect Workerd entrypoint. It does not change generated clients, public APIs, provider HTTP configuration, or Promise SDK behavior. The Slack consumer upgrade remains a follow-up after a published SDK contains the fix.
Verification
Using Bun 1.4.0:
createandlayerwith a conflicting Fetch at construction and call time, real router requests, durable event reads, live event subscription, typed not-found errors, and calls after host closure. No global Fetch mutation or network listener is used.websearch_provider_not_found) and Promise event cancellation expectation (iterator completion instead of a transport error); neither test was changed here.