fix(plugin): export Promise ToolEditor - #46950
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Promise plugin authors cannot import
ToolEditorto type reusable transform helpers: TypeScript reports that the module declares it locally but does not export it. The Effect API and the other public editor interfaces already export their editor types.What Changes
Export the existing Promise interface without changing its members:
Before: this named type import fails with TS2459. After: a separate source-linked consumer can import it and use the editor's methods.
Scope
One
exportkeyword. No runtime changes, method renames, or changes to the Effect API.Verification
The consumer check failed with TS2459 before the change and passed afterward. Package typechecking, all 9 plugin tests, formatting, and the normal pre-push workspace typecheck pass.
TMPDIRis canonicalized so the existing host-resolution tests compare the same filesystem path spelling on macOS.