feat(app): rename home sessions from the context menu - #46915
Draft
carthageadev wants to merge 2 commits into
Draft
feat(app): rename home sessions from the context menu#46915carthageadev wants to merge 2 commits into
carthageadev wants to merge 2 commits into
Conversation
6 tasks
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Related PR Found:
Why it's related: This PR is explicitly mentioned in the current PR's description as related. PR #46655 proposes a menu button approach for session renaming, while PR #46915 (current) adds a right-click context menu rename shortcut. The PR description notes these branches would need coordination before merging, as they offer alternative approaches to the same feature. The current PR (#46915) is the one being checked, so it's not a duplicate of itself—it's a complementary approach to a related feature already in flight. |
Author
|
(oops images work now) 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Related to #25848 and #46655. Design discussion. Draft pending maintainer feedback.
Type of change
What does this PR do?
Adds right-click -> Rename to Home session rows, matching tab renaming. Reuses the existing menu, inline input and rename API. Keeps the icon visible while editing.
This proposes a shortcut alongside #46655's menu button, not a replacement. The branches would need coordination before merging.
How did you verify your code works?
Seven new browser tests and five existing rename tests passed. The final icon fix passed the app typecheck and a focused visual check. Windows build and real-backend rename were checked locally. The cleaned branch has identical code.
Three unrelated heading-save tests also fail on the untouched release.
Screenshots / recordings
(oops images work now)
Checklist