fix(cli): preserve attached run output - #46896
Open
rekram1-node wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Found during live CLI testing. Related to the local-run fix in #31389.
Type of change
What does this PR do?
run --attachcan exit 0 before printing the final answer because the prompt request finishes before its event reader catches up.After a successful attached request, cancel/drain the event reader and replay missing output from the saved messages for that prompt. Reuse the existing renderer and deduplicate completed parts. This adds one history read per attached prompt/command, but does not depend on receiving an idle event. Local runs and immediate request-error handling stay unchanged.
How did you verify your code works?
bun test test/cli/run/run-process.test.ts --rerun-each 3: 48 passed.bun typecheck, Prettier, andgit diff --checkpassed.step_finish, using isolated databases.Screenshots / recordings
Not a UI change.
Checklist