Repository navigation
chore(systemtest): keep UpCloud lanes out of the default set - #516
Conversation
UpCloud is too costly to test on routinely, so the upcloud (Ankra-managed) and uks (cloud-managed) lanes leave the default provider lists in the script, the systemtest workflow (schedule and dispatch defaults) and the README. Both lanes still run when a caller names them. The lane-plan test now pins that a configured UpCloud credential does not pull either lane back into the default, and that naming them still runs them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ankra AI reviewVerdict: looks good. The change consistently removes upcloud/uks from the default lane sets across the workflow dispatch defaults, the scheduled-run env fallbacks, the shell script defaults, and the docs, and the test updates correctly reflect the new 8-lane default with an opt-in regression test. The arithmetic in the updated expectations (8 requested, 7 skipped, 1 runnable) checks out. CI is still running, so build status is unknown, but nothing in the diff itself looks broken. Findings
Reviewed commit 14e9a45. This review is read-only and advisory. |
| "::warning title=Lifecycle lanes skipped::7 of 8 provider lanes skipped", | ||
| "runnable: hetzner / managed: none", | ||
| }, | ||
| rejectOutput: []string{"upcloud", "uks"}, |
There was a problem hiding this comment.
[low] Substring rejection patterns may be brittle
rejectOutput entries "upcloud" and "uks" are short substrings; if the plan output ever prints, say, a secret name like SYSTEMTEST_UPCLOUD_CREDENTIAL_ID or a lane table mentioning the opt-in lanes even when not requested, this test would fail spuriously. I can't see how rejectOutput is matched (substring vs line) or the full expected summary table, so this may be fine, but consider matching whole lane tokens if the harness allows it.
Ankra AI review. Read-only and advisory.
|
On the low finding: the broad match is deliberate. In that case neither UpCloud lane is requested, so the plan output has no reason to mention |
Summary
UpCloud costs too much to use for routine lifecycle testing. This removes the
upcloud(Ankra-managed) anduks(cloud-managed) lanes from the default provider lists in:systemtest/lifecycle_systemtest.shsystemtest.ymlschedule and dispatch defaultssystemtest/README.mdBoth lanes still run when a caller names them, for example a dispatch with
providers: upcloudormanaged_providers: uks.Context: the 10-14 investigation of "could not resolve cluster id" (ankra-ews9qk, #510/#511) found the UpCloud test account out of credits. The decision is to stop testing on UpCloud routinely rather than top the account up.
Tests
TestLanePlannow checks that a configured UpCloud credential doesn't pull either lane back into the default set (8 lanes requested, the output never mentionsupcloudoruks).upcloudanduksstill runs them.go test ./...andgolangci-lint(0 issues).Bead: ankra-umo466
🤖 Generated with Claude Code