feat: support rich Menu action content#57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Menuitem shape with structuredactionsMenuActionwithtitle,description,leading,trailing,selected,disabled,intent, andactivateTextMenuActionandMenuActionIntentfrom the component and root barrelsCloses #56.
Notes
This intentionally does not preserve the previous
items/labelAPI because SurfaceMenuhas not been consumed yet. This PR uses the opportunity to make the first real public API cleaner:actionsinstead ofitemstitleinstead oflabelactivateinstead ofonPressdismissinstead ofonDismissintent: 'default' | 'danger'instead of a broad color APIThe existing
MenuItemexport remains as an alias ofMenuActionfor compatibility with the current barrel naming, butMenuActionis the preferred type name.Verification
Not run locally in this environment because the connected GitHub API path cannot execute repo commands. Please run before merge:
bun run build bun run lint:fix bun run test