Add note about safety_assured not carrying over during rollback#317
Open
55728 wants to merge 1 commit intoankane:masterfrom
Open
Add note about safety_assured not carrying over during rollback#31755728 wants to merge 1 commit intoankane:masterfrom
55728 wants to merge 1 commit intoankane:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284.
When using
safety_assuredwithadd_columninside achangemethod, thesafety_assuredcontext does not carry over when Rails reverts the migration. This can be confusing whencheck_downis enabled, as the rollback hits theremove_columncheck with no indication of whysafety_assureddidn't help.Building on d15e3fa which improved the error output formatting for rollbacks, this adds a brief note to the message content itself suggesting the use of
upanddownmethods instead.