Repository navigation
fix(cdk/portal): insert DOM portal in right location - #34055
Merged
Merged
Conversation
Fixes that if a DOM portal is attached to an `ng-template`, we were inserting the content into the end of the parent, rather than the portal outlet location. Fixes angular#34025.
ok7sai
approved these changes
Nov 4, 2026
Member
Author
crisbeto
added a commit
that referenced
this pull request
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that if a DOM portal is attached to an
ng-template, we were inserting the content into the end of the parent, rather than the portal outlet location.Fixes #34025.