docs: type the external redirect guard - #33887
Merged
Merged
Conversation
`externalRedirect()` passed its guard to `canActivate` as an inline arrow function. `canActivate` accepts `CanActivateFn` as well as the deprecated class-based guards, typed as `ProviderToken<any>`. Any function also matches `ProviderToken<any>`, so TypeScript didn't check the inline guard against `CanActivateFn`. For example, a guard returning a number would still compile. This declares the guard as a `CanActivateFn` before passing it to `canActivate`, so its return value is type checked. The behavior is unchanged. A comment explains why the type is needed, so it isn't inlined again later.
crisbeto
approved these changes
Sep 29, 2026
crisbeto
added
action: merge
Member
crisbeto
pushed a commit
that referenced
this pull request
Sep 29, 2026
`externalRedirect()` passed its guard to `canActivate` as an inline arrow function. `canActivate` accepts `CanActivateFn` as well as the deprecated class-based guards, typed as `ProviderToken<any>`. Any function also matches `ProviderToken<any>`, so TypeScript didn't check the inline guard against `CanActivateFn`. For example, a guard returning a number would still compile. This declares the guard as a `CanActivateFn` before passing it to `canActivate`, so its return value is type checked. The behavior is unchanged. A comment explains why the type is needed, so it isn't inlined again later. (cherry picked from commit 1543543)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
externalRedirect()passed its guard tocanActivateas an inline arrow function.canActivateacceptsCanActivateFnas well as the deprecated class-based guards, typed asProviderToken<any>. Any function also matchesProviderToken<any>, so TypeScript didn't check the inline guard againstCanActivateFn. For example, a guard returning a number would still compile.This declares the guard as a
CanActivateFnbefore passing it tocanActivate, so its return value is type checked. The behavior is unchanged. A comment explains why the type is needed, so it isn't inlined again later.