Update README.md to include Firebase Data Connect#3673
Conversation
armando-navarro
left a comment
armando-navarro
left a comment
There was a problem hiding this comment.
Hi @maneesht - thanks for this, and sorry it sat so long. I've recently taken over maintenance and I'm working through the PR backlog. Data Connect absolutely belongs in the README's feature table, so I'd like to get this in. Two things need fixing first:
The link target doesn't exist
docs/data-connect.md isn't in the repo, so the heading would link to a 404. Until an AngularFire-specific docs page exists, could you point it at the official Data Connect docs (https://firebase.google.com/docs/data-connect) instead? (A docs/data-connect.md in the style of the other feature pages would be even better, if you're up for it - but I won't block on that.)
The new cell lands in the wrong row
The feature table is two columns, and this inserts a third into the Cloud Firestore / Cloud Functions row, which renders a strange-looking 3rd row that can only be seen by scrolling horizontally. The last row currently has an empty slot next to Vertex AI - moving the Data Connect cell there keeps the table balanced.
Happy to take care of it
Happy to take this over and make both tweaks myself if you'd rather - just say the word. Otherwise I'll merge once they're in.
2 participants
No description provided.