build: update beasties to 0.5.1 - #34014
Merged
Merged
Conversation
alan-agius4
added
action: review
angular-robot
Bot
added
the
area: build & ci
alan-agius4
marked this pull request as ready for review
September 3, 2026 12:27
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the beasties dependency to version 0.5.1 and refactors the inline critical CSS processing logic to utilize its new features, such as the native nonce option and the data-beasties-media attribute. The review feedback highlights a potential Content Security Policy (CSP) bypass risk where returning null instead of undefined for the CSP nonce could cause Beasties to output a literal nonce="null" attribute. Additionally, defensive programming is suggested by using optional chaining when calling remove() on elements cast to any to prevent potential runtime crashes.
alan-agius4
force-pushed
the
build/udate-beasties
branch
from
September 3, 2026 12:50
93cfd0d to
1600c1a
Compare
alan-agius4
removed
the
action: review
alan-agius4
force-pushed
the
build/udate-beasties
branch
from
September 3, 2026 13:36
1600c1a to
b20f287
Compare
Updates Beasties to version 0.5.1 and simplifies the inline critical CSS implementation in @angular/build and @angular/ssr by using Beasties' native preload: 'media-script' and nonce callback support. Additionally, refactors `inlineCriticalCss` in @angular/build into a standalone function and relocates `InlineCriticalCssProcessor` into @angular-devkit/build-angular for Webpack-based builders.
alan-agius4
force-pushed
the
build/udate-beasties
branch
from
September 3, 2026 14:37
b20f287 to
521feec
Compare
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Beasties to version 0.5.1 and simplifies the inline critical CSS
implementation in @angular/build and @angular/ssr by using Beasties'
native preload: 'media-script' and nonce callback support.
Additionally, refactors
inlineCriticalCssin @angular/build into astandalone function and relocates
InlineCriticalCssProcessorinto@angular-devkit/build-angular for Webpack-based builders.