refactor(@angular/build): unify configuration loading and option transformations in TypeScriptCompilation - #34007
Open
clydin wants to merge 1 commit into
Open
Conversation
…sformations in TypeScriptCompilation Both AotCompilation and JitCompilation previously executed identical logic during initialization to read tsconfig.json using readConfiguration and immediately pass the options to transformCompilerOptions. The loadConfiguration method on TypeScriptCompilation now accepts optional compilerOptionOverrides and applies transformCompilerOptions directly. This unifies configuration reading and option transformations into a single cohesive step, eliminates duplicate setup boilerplate across AotCompilation and JitCompilation, and reduces unnecessary direct imports of transformCompilerOptions.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the TypeScript compilation process by centralizing the compiler option transformation logic inside the base TypeScriptCompilation class's loadConfiguration method. This simplifies the AotCompilation and JitCompilation subclasses, which previously handled this transformation separately. Additionally, a new unit test has been added to verify that configuration loading and compiler option transformations function correctly. I have no feedback to provide as the changes are clean and well-tested.
alan-agius4
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
AotCompilationandJitCompilationpreviously executed identical logic during initialization to readtsconfig.jsonusingreadConfigurationand immediately pass the options totransformCompilerOptions.The loadConfiguration method on
TypeScriptCompilationnow accepts optionalcompilerOptionOverridesand appliestransformCompilerOptionsdirectly. This unifies configuration reading and option transformations into a single cohesive step, eliminates duplicate setup boilerplate acrossAotCompilationandJitCompilation, and reduces unnecessary direct imports oftransformCompilerOptions.