build: update beasties to 0.5.1 - #33990
Conversation
angular-robot
Bot
added
the
area: build & ci
alan-agius4
added
the
target: minor
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the beasties dependency to version 0.5.0 and refactors InlineCriticalCssProcessor to leverage native CSP nonce and preload features, simplifying the codebase by removing custom overrides. Additionally, outputPath has been moved from the process options to the constructor options of IndexHtmlGenerator, with corresponding updates across builders, plugins, and tests. A critical issue was identified in IndexHtmlWebpackPlugin where passing the full file path instead of the directory path to super() will break path resolution during Webpack builds.
74579dc to
760c822
Compare
760c822 to
fcb6344
Compare
alan-agius4
changed the title
alan-agius4
added
action: review
fcb6344 to
e18a2b2
Compare
Updates Beasties to version 0.5.1 and simplifies the inline critical CSS implementation in @angular/build and @angular/ssr by using Beasties' native preload: 'media-script' and nonce callback support. Additionally, refactors `inlineCriticalCss` in @angular/build into a standalone function and relocates `InlineCriticalCssProcessor` into @angular-devkit/build-angular for Webpack-based builders.
e18a2b2 to
8cfd070
Compare
alan-agius4
added
state: blocked
action: review
There was a problem hiding this comment.
Code Review
This pull request upgrades the beasties dependency from version 0.4.3 to 0.5.1 and refactors the critical CSS inlining logic across several packages. The custom overrides and manual script injections previously used to handle CSP nonces and asynchronous stylesheet loading have been replaced by native beasties options, such as preload: 'media-script' and the nonce callback. Additionally, the InlineCriticalCssProcessor has been simplified, and corresponding tests and builder integrations have been updated to reflect the new data-beasties-media attribute. Feedback on this PR includes a reminder to remove the temporary 'beasties' exclusion and its associated TODO comment from pnpm-workspace.yaml before merging.
1 participant
Updates Beasties to version 0.5.1 and simplifies the inline critical CSS implementation in @angular/build and @angular/ssr by using Beasties' native
preload: 'media-script'andnoncecallback support.Additionally, refactors
inlineCriticalCssin @angular/build into a standalone function and relocatesInlineCriticalCssProcessorinto @angular-devkit/build-angular for Webpack-based builders.