fix(@angular/ssr): replace all route parameters when resolving relative redirects#33606
Closed
alan-agius4 wants to merge 1 commit into
Closed
fix(@angular/ssr): replace all route parameters when resolving relative redirects#33606alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
…ve redirects Fixes angular#33603 Backport of 0bd22da to the 21.2.x branch.
alan-agius4
added
the
target: patch
alan-agius4
added
the
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the route redirection resolution in Angular SSR to support multiple path parameters by replacing URL_PARAMETER_REGEXP with URL_PARAMETER_GLOBAL_REGEXP when resolving relative redirects. It also adds a corresponding unit test to verify that nested redirects with multiple path parameters are extracted correctly. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33603. Backport of 0bd22da to the 21.2.x branch.