Skip to content

refactor: move eslint disable comment to top of file - #33383

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:eslint-disable
Jun 16, 2026
Merged

refactor: move eslint disable comment to top of file#33383
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:eslint-disable

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

No description provided.

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jun 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the code by removing multiple inline eslint-disable-next-line max-lines-per-function comments and attempting to disable the rule file-wide at the top of the file. However, the newly added file-wide disable comment uses line comment syntax (//) instead of block comment syntax (/* ... */), which is not recognized by ESLint. A suggestion has been provided to correct this syntax so the rule is successfully disabled.

Comment thread packages/angular_devkit/build_angular/src/builders/browser/index.ts Outdated
@alan-agius4
alan-agius4 merged commit a527d02 into angular:main Jun 16, 2026
14 checks passed
@alan-agius4
alan-agius4 deleted the eslint-disable branch June 16, 2026 09:08
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants