perf(@angular/cli): implement semaphore backpressure throttling in PackageManager - #33375
Merged
alan-agius4 merged 1 commit intoJun 16, 2026
Merged
Conversation
angular-robot
Bot
added
area: performance
clydin
marked this pull request as ready for review
June 15, 2026 14:48
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces concurrency throttling to the PackageManager class, limiting concurrent executions to a maximum of 5. The review feedback recommends simplifying the queue mechanism by removing the unused reject callback from the pending tasks array and the throttling logic, which reduces unnecessary complexity.
…ckageManager Execute package manager subprocess invocations using a semaphore-based backpressure throttle. When callers perform concurrent registry lookups (such as running Promise.all over candidate update packages), this prevents unbounded child subprocess spawning. Clamping active concurrent CLI commands to a fixed limit protects the operating system against process table exhaustion, V8 heap saturation, and upstream registry rate-limiting while maintaining fast execution.
clydin
force-pushed
the
refactor-package-manager-concurrency
branch
from
June 15, 2026 15:02
a7be714 to
4a5b437
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Jun 16, 2026
alan-agius4
added
action: merge
Collaborator
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Execute package manager subprocess invocations using a semaphore-based backpressure throttle.
When callers perform concurrent registry lookups (such as running Promise.all over candidate update packages), this prevents unbounded child subprocess spawning. Clamping active concurrent CLI commands to a fixed limit protects the operating system against process table exhaustion, V8 heap saturation, and upstream registry rate-limiting while maintaining fast execution.