Skip to content

fix(@angular/ssr): correct grammar in console warning for redirected location headers - #33351

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:redirect-message
Jun 11, 2026
Merged

fix(@angular/ssr): correct grammar in console warning for redirected location headers#33351
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:redirect-message

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

The console message had incorrect grammer.

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jun 11, 2026
@alan-agius4
alan-agius4 requested a review from dgp1130 June 11, 2026 09:02
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a minor grammatical typo in a console warning message within packages/angular/ssr/src/utils/redirect.ts, changing 'will ignored' to 'will be ignored'. There are no review comments, and I have no feedback to provide as the change is correct and straightforward.

…location headers

The console message had incorrect grammer.
@hawkgs hawkgs removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 11, 2026
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 11, 2026
@alan-agius4
alan-agius4 removed the request for review from dgp1130 June 11, 2026 15:31
@alan-agius4
alan-agius4 merged commit ddcef9d into angular:main Jun 11, 2026
38 of 39 checks passed
@alan-agius4
alan-agius4 deleted the redirect-message branch June 11, 2026 15:31
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@ngbot

ngbot Bot commented Jun 11, 2026

Copy link
Copy Markdown

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants