perf(@angular/cli): optimize update schematic registry query counts by fetching package metadata lazily - #33316
Conversation
65c19d8 to
4ccde3d
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the Angular CLI update command to pass and utilize the workspaceRoot for package resolution, enabling support for Yarn Plug'n'Play (PnP) and lazy dependency resolution. The review feedback highlights two critical improvements: first, replacing the platform-sensitive new URL construction with path.join to prevent Windows-specific path resolution errors, which also allows simplifying the logic by using createRequire as a general fallback; second, adding a safe guard when accessing npmPackageJson['dist-tags'] to prevent potential TypeError crashes when the property is undefined.
4ccde3d to
574809d
Compare
…y fetching package metadata lazily Optimize the ng update registry requests by only querying package metadata for packages that are actually being updated, while resolving other dependencies locally from disk (with fallback to registry for uninstalled/mocked packages). This reduces network query counts by 80-90% during ng update.
574809d to
ebd4970
Compare
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Optimize the ng update registry requests by only querying package metadata for packages that are actually being updated, while resolving other dependencies locally from disk (with fallback to registry for uninstalled/mocked packages). This reduces network query counts by 80-90% during ng update.