fix(@schematics/angular): use null objects and callbacks in karma-to-vitest migration - #33309
Merged
clydin merged 1 commit intoJun 9, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the Karma-to-Vitest migration schematics by using Object.create(null) to mitigate prototype pollution and wrapping string replacements in functions to prevent issues with special replacement patterns. However, a potential prototype pollution vulnerability remains in migration.ts when iterating over customBuildOptions keys, as unsafe keys like __proto__ are not explicitly skipped.
clydin
force-pushed
the
fix-karma-to-vitest-migration-templates
branch
from
June 4, 2026 17:32
56a8846 to
e322401
Compare
…vitest migration The karma-to-vitest migration schematic previously used plain JavaScript objects as dictionaries when processing custom build options and analyzing Karma AST configurations. In environments where the input workspace files contain custom keys such as "__proto__", these assignments would leak properties onto the global Object prototype.
clydin
force-pushed
the
fix-karma-to-vitest-migration-templates
branch
from
June 8, 2026 15:08
e322401 to
cde493d
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Jun 9, 2026
alan-agius4
added
action: merge
Member
Author
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The karma-to-vitest migration schematic previously used plain JavaScript objects as dictionaries when processing custom build options and analyzing Karma AST configurations. In environments where the input workspace files contain custom keys such as
__proto__these assignments would leak properties onto the global Object prototype.