docs: update JSDoc return tag to @return in registry.ts - #33204
Merged
Conversation
clydin
force-pushed
the
fix/jsdoc-return-tag
branch
from
May 14, 2026 13:28
3d544cb to
fcd5d17
Compare
clydin
changed the title
@return in registry.ts
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the JSDoc tag from @returns to @return for the ɵflatten method in the CoreSchemaRegistry class. A review comment correctly identifies that the documentation still incorrectly specifies an Observable return type instead of a Promise and provides a code suggestion to rectify this.
clydin
force-pushed
the
fix/jsdoc-return-tag
branch
from
May 14, 2026 13:43
fcd5d17 to
9361837
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
May 14, 2026
alan-agius4
added
action: merge
Member
Author
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.