Skip to content

refactor(@angular/cli): migrate MCP zoneless tool to host abstraction - #33133

Merged
clydin merged 1 commit into
angular:mainfrom
clydin:refactor/mcp-zoneless-host
May 8, 2026
Merged

refactor(@angular/cli): migrate MCP zoneless tool to host abstraction#33133
clydin merged 1 commit into
angular:mainfrom
clydin:refactor/mcp-zoneless-host

Conversation

@clydin

@clydin clydin commented May 5, 2026

Copy link
Copy Markdown
Member

Migrate the zoneless migration tool to use the Host abstraction for file system operations including reading files, checking stats, and globbing. This ensures that the tool adheres to the allowed roots configured in the MCP server. By removing direct dependencies on native Node.js fs modules, the tool now benefits from the centralized injection and restriction model provided by the Host implementation.

@clydin
clydin force-pushed the refactor/mcp-zoneless-host branch from 45dc998 to 225778b Compare May 5, 2026 20:46
@clydin
clydin marked this pull request as ready for review May 5, 2026 20:47

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the zoneless migration tool to use a Host abstraction for file system operations instead of direct node:fs calls. This involves updating several functions and tests to accept and utilize the Host interface. A review comment identifies a potential type mismatch in the Host implementation following the update of the readFile signature to use BufferEncoding.

Comment thread packages/angular/cli/src/commands/mcp/host.ts
Migrate the zoneless migration tool to use the Host abstraction for file system operations including reading files, checking stats, and globbing. This ensures that the tool adheres to the allowed roots configured in the MCP server. By removing direct dependencies on native Node.js fs modules, the tool now benefits from the centralized injection and restriction model provided by the Host implementation.
@clydin
clydin force-pushed the refactor/mcp-zoneless-host branch from 225778b to 1671504 Compare May 5, 2026 20:54
@clydin clydin added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels May 5, 2026
@clydin
clydin requested a review from alan-agius4 May 5, 2026 23:57
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 8, 2026
@clydin
clydin merged commit 66ec762 into angular:main May 8, 2026
37 checks passed
@clydin

clydin commented May 8, 2026

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

@clydin
clydin deleted the refactor/mcp-zoneless-host branch May 8, 2026 12:51
@angular-automatic-lock-bot

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/cli target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants