refactor(@angular/cli): restrict MCP host process spawning to Angular CLI executable - #33132
Conversation
78a278f to
352e6d4
Compare
There was a problem hiding this comment.
Code Review
This pull request refactors the Host interface by renaming runCommand to executeNgCommand and spawn to startNgProcess, while removing the redundant command parameter as these methods now specifically target the Angular CLI. These changes are consistently applied across the devserver, build, e2e, and test tools, as well as their mock implementations and unit tests. Feedback identifies that the options parameters in the createRootRestrictedHost implementation are typed too narrowly, which may cause properties like timeout, stdio, or env to be inaccessible or lost when delegating to the base host.
352e6d4 to
edde1be
Compare
… CLI executable Update the Host abstraction inside the Model Context Protocol (MCP) layer to tighten the system shell surface and improve semantics. The generic spawn and execute methods are replaced with specialized counterparts that default to the Angular CLI, enabling stronger path security containment for developers while also clarifying the distinct control flows needed for buffered discrete commands and long-running background services.
edde1be to
e1aaddd
Compare
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Update the Host abstraction inside the Model Context Protocol (MCP) layer to tighten the system shell surface and improve semantics. The generic spawn and execute methods are replaced with specialized counterparts that default to the Angular CLI, enabling stronger path security containment for developers while also clarifying the distinct control flows needed for buffered discrete commands and long-running background services.